webgrip/invoiceninja-application
5
0
Fork 0
Code Issues 12 Pull requests 1 Projects Releases Packages Wiki Activity Actions

[PR #6] [MERGED] Set up Invoice Ninja Docker infrastructure with self-maintained images #47

New issue
Closed
opened 2026-06-08 09:15:49 +00:00 by ryangr0 · 0 comments
ryangr0 commented 2026-06-08 09:15:49 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/webgrip/invoiceninja-application/pull/6
Author: @Copilot
Created: 9/3/2025
Status: ✅ Merged
Merged: 9/3/2025
Merged by: @Ryangr0

Base: main ← Head: copilot/fix-4

📝 Commits (4)

  • c5927d3 Initial plan
  • 5b2d07c Complete Docker setup with all services working correctly
  • 65bff12 docs: Add comprehensive Docker infrastructure documentation
  • 7528820 feat: Switch from Node.js template to actual Invoice Ninja application

📊 Changes

15 files changed (+652 additions, -148 deletions)

View changed files

📝 Makefile (+1 -1)
📝 README.md (+35 -2)
📝 docker-compose.yml (+50 -10)
➕ docs/adrs/0005-self-maintained-docker-image-policy.md (+124 -0)
➕ docs/techdocs/docs/docker.md (+367 -0)
📝 docs/techdocs/mkdocs.yml (+1 -0)
📝 ops/docker/application/Dockerfile (+14 -30)
📝 ops/docker/mariadb/Dockerfile (+6 -1)
➕ ops/docker/mkcert/Dockerfile (+9 -0)
📝 ops/docker/nginx/Dockerfile (+10 -4)
📝 ops/docker/nginx/config/default.conf (+16 -21)
📝 ops/docker/postgres/Dockerfile (+5 -1)
📝 ops/docker/redis/Dockerfile (+5 -1)
📝 package.json (+9 -28)
➖ src/index.js (+0 -49)

📄 Description

This PR implements a complete self-maintained image policy for the invoiceninja-application project, ensuring all services run from org-owned images built from the official Invoice Ninja application with proper containerization best practices.

Summary of Changes

Docker Infrastructure

  • Updated all Dockerfiles to use latest stable minor versions with exact pinned tags
  • Added nginx reverse proxy service with proper Invoice Ninja backend configuration
  • Created mkcert service for local SSL certificate generation
  • Fixed docker-compose.yml to reference only org-owned images with correct build contexts

Service Configuration

  • Application: Uses actual Invoice Ninja v5.x image (invoiceninja/invoiceninja:5) with minimal overlay
  • MariaDB: Pinned to mariadb:11.6.2-noble with optimized startup configuration
  • Redis: Updated to redis:7.4.2-alpine for latest stable features
  • Nginx: Configured with nginx:1.26.2-alpine as reverse proxy for Invoice Ninja on port 80
  • PostgreSQL: Available as alternative with postgres:17.2-alpine

Security & Best Practices

  • Port hygiene: Only nginx publishes to host (127.0.0.1:8080), all other services use internal networking
  • Health checks: Implemented comprehensive health monitoring for all services with Invoice Ninja's built-in health endpoint
  • Non-root users: All services run with appropriate user permissions
  • Minimal overlays: Only essential additions to upstream images (curl for health checks)

Developer Experience

  • Fixed Makefile compatibility for both docker compose and docker-compose
  • Service dependencies: Proper startup ordering with health check dependencies
  • Complete lifecycle: make start → working Invoice Ninja stack → make stop with clean shutdown

Documentation

  • Comprehensive Docker documentation in TechDocs format covering Invoice Ninja architecture, troubleshooting, and best practices
  • Enhanced README with Docker overview and quick start guide for Invoice Ninja deployment
  • ADR-0005 documenting self-maintained image policy decisions and rationale
  • Updated navigation to include Docker infrastructure documentation

Validation

The implementation provides a working Invoice Ninja deployment:

# Complete lifecycle works correctly
make start  # All services healthy
curl http://localhost:8080/        # Returns Invoice Ninja application
curl http://localhost:8080/health  # Returns health status from Invoice Ninja
make stop   # Clean shutdown

All services achieve healthy status with proper dependency ordering and the nginx reverse proxy correctly serves the Invoice Ninja Laravel application.

Policy Compliance

✅ Own every image: All services use webgrip/invoiceninja-application.{service} naming
✅ Upstream as base: Direct FROM official Invoice Ninja and other official images with exact pinned tags
✅ Minimal overlay: Only essential additions, no unnecessary packages
✅ Compose uses our images only: No direct upstream references
✅ Port hygiene: Only reverse proxy publishes host ports
✅ Reproducibility: Clean clone → make start → working Invoice Ninja stack

Fixes #4.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/webgrip/invoiceninja-application/pull/6 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 9/3/2025 **Status:** ✅ Merged **Merged:** 9/3/2025 **Merged by:** [@Ryangr0](https://github.com/Ryangr0) **Base:** `main` ← **Head:** `copilot/fix-4` --- ### 📝 Commits (4) - [`c5927d3`](https://github.com/webgrip/invoiceninja-application/commit/c5927d35219d6f7a78a7151467136b90646abb07) Initial plan - [`5b2d07c`](https://github.com/webgrip/invoiceninja-application/commit/5b2d07c0c381a062ea6ae01e3e6ee0fdac60b9a5) Complete Docker setup with all services working correctly - [`65bff12`](https://github.com/webgrip/invoiceninja-application/commit/65bff122deff5f2e326030a967ca68ab6af461c0) docs: Add comprehensive Docker infrastructure documentation - [`7528820`](https://github.com/webgrip/invoiceninja-application/commit/7528820ea04e86e18905a90b2f26a4cde4bc9eff) feat: Switch from Node.js template to actual Invoice Ninja application ### 📊 Changes **15 files changed** (+652 additions, -148 deletions) <details> <summary>View changed files</summary> 📝 `Makefile` (+1 -1) 📝 `README.md` (+35 -2) 📝 `docker-compose.yml` (+50 -10) ➕ `docs/adrs/0005-self-maintained-docker-image-policy.md` (+124 -0) ➕ `docs/techdocs/docs/docker.md` (+367 -0) 📝 `docs/techdocs/mkdocs.yml` (+1 -0) 📝 `ops/docker/application/Dockerfile` (+14 -30) 📝 `ops/docker/mariadb/Dockerfile` (+6 -1) ➕ `ops/docker/mkcert/Dockerfile` (+9 -0) 📝 `ops/docker/nginx/Dockerfile` (+10 -4) 📝 `ops/docker/nginx/config/default.conf` (+16 -21) 📝 `ops/docker/postgres/Dockerfile` (+5 -1) 📝 `ops/docker/redis/Dockerfile` (+5 -1) 📝 `package.json` (+9 -28) ➖ `src/index.js` (+0 -49) </details> ### 📄 Description This PR implements a complete **self-maintained image policy** for the invoiceninja-application project, ensuring all services run from org-owned images built from the official Invoice Ninja application with proper containerization best practices. ## Summary of Changes ### Docker Infrastructure - **Updated all Dockerfiles** to use latest stable minor versions with exact pinned tags - **Added nginx reverse proxy service** with proper Invoice Ninja backend configuration - **Created mkcert service** for local SSL certificate generation - **Fixed docker-compose.yml** to reference only org-owned images with correct build contexts ### Service Configuration - **Application**: Uses actual Invoice Ninja v5.x image (`invoiceninja/invoiceninja:5`) with minimal overlay - **MariaDB**: Pinned to `mariadb:11.6.2-noble` with optimized startup configuration - **Redis**: Updated to `redis:7.4.2-alpine` for latest stable features - **Nginx**: Configured with `nginx:1.26.2-alpine` as reverse proxy for Invoice Ninja on port 80 - **PostgreSQL**: Available as alternative with `postgres:17.2-alpine` ### Security & Best Practices - **Port hygiene**: Only nginx publishes to host (127.0.0.1:8080), all other services use internal networking - **Health checks**: Implemented comprehensive health monitoring for all services with Invoice Ninja's built-in health endpoint - **Non-root users**: All services run with appropriate user permissions - **Minimal overlays**: Only essential additions to upstream images (curl for health checks) ### Developer Experience - **Fixed Makefile compatibility** for both `docker compose` and `docker-compose` - **Service dependencies**: Proper startup ordering with health check dependencies - **Complete lifecycle**: `make start` → working Invoice Ninja stack → `make stop` with clean shutdown ### Documentation - **Comprehensive Docker documentation** in TechDocs format covering Invoice Ninja architecture, troubleshooting, and best practices - **Enhanced README** with Docker overview and quick start guide for Invoice Ninja deployment - **ADR-0005** documenting self-maintained image policy decisions and rationale - **Updated navigation** to include Docker infrastructure documentation ## Validation The implementation provides a working Invoice Ninja deployment: ```bash # Complete lifecycle works correctly make start # All services healthy curl http://localhost:8080/ # Returns Invoice Ninja application curl http://localhost:8080/health # Returns health status from Invoice Ninja make stop # Clean shutdown ``` All services achieve healthy status with proper dependency ordering and the nginx reverse proxy correctly serves the Invoice Ninja Laravel application. ## Policy Compliance ✅ **Own every image**: All services use `webgrip/invoiceninja-application.{service}` naming ✅ **Upstream as base**: Direct FROM official Invoice Ninja and other official images with exact pinned tags ✅ **Minimal overlay**: Only essential additions, no unnecessary packages ✅ **Compose uses our images only**: No direct upstream references ✅ **Port hygiene**: Only reverse proxy publishes host ports ✅ **Reproducibility**: Clean clone → make start → working Invoice Ninja stack Fixes #4. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
ryangr0 2026-06-08 09:15:49 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/webgrip-workflows-digest
renovate/nginx-1.x
renovate/invoiceninja-invoiceninja-5.x
renovate/redis-8.x
renovate/postgres-18.x
renovate/mariadb-12.x
renovate/postgres-17.x
renovate/mariadb-11.x
renovate/redis-7.x
renovate/nginxinc-nginx-unprivileged-1.x
gh-pages
1.0.74
1.0.73
1.0.72
1.0.71-rc.1
1.0.71
1.0.70
1.0.70-dev.1
1.0.69
1.0.68
1.0.67
1.0.67-dev.1
1.0.66
1.0.65-dev.2
1.0.65
1.0.65-dev.1
1.0.64
1.0.63
1.0.62
1.0.62-dev.1
1.0.61
1.0.61-dev.1
1.0.60
1.0.59
1.0.59-dev.1
1.0.58
1.0.57
1.0.57-dev.1
1.0.56
1.0.56-dev.1
1.0.55
1.0.55-dev.1
1.0.54
1.0.54-dev.1
1.0.53-dev.1
1.0.53
1.0.52
1.0.51
1.0.50
1.0.49
1.0.48
1.0.47
1.0.46
1.0.45
1.0.44
1.0.43
1.0.42
1.0.41
1.0.40
1.0.39
1.0.38
1.0.37
1.0.36
1.0.35
1.0.34
1.0.33
1.0.32
1.0.31
1.0.30
1.0.29
1.0.28
1.0.27
1.0.26
1.0.25
1.0.24
1.0.23
1.0.22
1.0.21
1.0.20
1.0.19
1.0.18
1.0.17
1.0.16
1.0.15
1.0.14
1.0.13
1.0.12
1.0.11
1.0.10
1.0.9
1.0.8
1.0.7
1.0.6
1.0.5
1.0.4
1.0.3
1.0.2
1.0.1
1.0.0
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webgrip/invoiceninja-application#47
No description provided.