webgrip/unfold
5
0
Fork 0
Code Issues 1 Pull requests 2 Projects Releases 56 Packages 8 Wiki Activity Actions

test(unfold): space editor polls from the answer, not the request #229

Merged
ryangr0 merged 1 commit from ryangr0/fix/editor-poll-flake into development 2026-10-04 16:38:16 +00:00 AGit
Conversation 0 Commits 1 Files changed 1 +2 -1
ryangr0 commented 2026-10-04 16:33:39 +00:00
Owner
Copy link

Fixes the checks failure on development, run 962: api-editor-sign-in.test.ts "the phishing flow fails" got 429 slow_down where it expected 403.

The test's poll helper recorded its last-poll time before sending the request, but the server records it when the request arrives. When one poll arrived late on the busy runner and the next one arrived on time, the server measured less than its one-second minimum between polls. The helper now records the time after the response comes back, so the server always sees at least 1050 ms between polls.

Verified: the test file passes alone and in 8 parallel copies run at the same time.

🤖 Generated with Claude Code

Fixes the `checks` failure on development, run 962: `api-editor-sign-in.test.ts` "the phishing flow fails" got `429 slow_down` where it expected `403`. The test's `poll` helper recorded its last-poll time before sending the request, but the server records it when the request arrives. When one poll arrived late on the busy runner and the next one arrived on time, the server measured less than its one-second minimum between polls. The helper now records the time after the response comes back, so the server always sees at least 1050 ms between polls. Verified: the test file passes alone and in 8 parallel copies run at the same time. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
test(unfold): space editor polls from the answer, not the request
Some checks failed
[Workflow] On Pull Request / checks (pull_request) Has been cancelled
Details
[Workflow] On Pull Request / warnings (pull_request) Has been cancelled
Details
[Workflow] On Pull Request / ploeg-pin (pull_request) Has been cancelled
Details
[Workflow] On Pull Request / release-policy (pull_request) Has been cancelled
Details
fb252a2878
 
The phishing-flow test failed on a loaded runner (run 962) with 429
slow_down instead of 403. The helper stamped its last poll before
sending, while the server stamps on arrival, so a delayed poll followed
by a prompt one landed under the server's one-second floor. Stamping
after the response guarantees the server sees at least 1050 ms.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ryangr0 merged commit 0260f4fee7 into development 2026-10-04 16:38:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
webgrip/unfold!229
No description provided.