docs(kpis): point the KPI proposal at VIK-1214/VIK-1215 and mark cfd6ec4 landed #4

Merged

ryangr0 merged 2 commits from agent/vik-1289 into development 2026-09-28 04:11:47 +00:00

Conversation 2 Commits 2 Files changed 1 +14 -14

agent-builder commented 2026-09-27 18:11:07 +00:00

Member

Copy link

What / why

Fixes the KPI reference page's drift against the tracker:

• The status line cited backlog #91/#92 (which are "Golden fixtures" and "CI hardening") as the KPI proposal; it now links the KPI set VIK-1214 and the dashboard VIK-1215.
• The merge settlement cfd6ec4 is merged and released, so K5's Source, K5's SQL comment, K6's proxy note and the Data tickets table no longer describe it as pending. Data row D4 is marked done.
• The Data tickets table gained a Status column so D4's state is explicit.
• Refreshed last_verified: 2026-09-27 and verified_by.

Evidence

• grep -nE '#91|#92|not on development' docs/reference/kpis.md -> no matches.
• sh $PLOEG_VERIFY_SCRIPT -> all 1 checks passed (gofmt).
• python3 scripts/docs.py --check -> all docs unit tests OK, page front matter valid, 376 sources / 1981 repository links resolved, ADR consistency OK; it stops only at the mkdocs build --strict step because mkdocs is not installed in the sandbox.

Checks left to CI

• mkdocs build --strict and scripts/docs-output.py: MkDocs toolchain is not installed in this sandbox and there is no registry egress to install it.
• Vale prose lint (docs-vale.test.py, reported as skipped locally): the vale binary is unavailable here.

Risk notes

• Docs only; docs/reference/kpis.md is the sole changed file. apps/ploeg/docs/backlog.md, tests and CI config are untouched (protected areas).
• New links are external tracker URLs on the same instance the rest of the docs already use.

Correct base branch is development (the tooling may default to main); please retarget if needed.

Refs VIK-1289

## What / why Fixes the KPI reference page's drift against the tracker: - The status line cited backlog #91/#92 (which are "Golden fixtures" and "CI hardening") as the KPI proposal; it now links the KPI set [VIK-1214](https://vikunja.webgrip.dev/tasks/1214) and the dashboard [VIK-1215](https://vikunja.webgrip.dev/tasks/1215). - The merge settlement `cfd6ec4` is merged and released, so K5's Source, K5's SQL comment, K6's proxy note and the Data tickets table no longer describe it as pending. Data row D4 is marked **done**. - The Data tickets table gained a Status column so D4's state is explicit. - Refreshed `last_verified: 2026-09-27` and `verified_by`. ## Evidence - `grep -nE '#91|#92|not on development' docs/reference/kpis.md` -> no matches. - `sh $PLOEG_VERIFY_SCRIPT` -> all 1 checks passed (gofmt). - `python3 scripts/docs.py --check` -> all docs unit tests OK, page front matter valid, 376 sources / 1981 repository links resolved, ADR consistency OK; it stops only at the `mkdocs build --strict` step because `mkdocs` is not installed in the sandbox. ## Checks left to CI - `mkdocs build --strict` and `scripts/docs-output.py`: MkDocs toolchain is not installed in this sandbox and there is no registry egress to install it. - Vale prose lint (`docs-vale.test.py`, reported as skipped locally): the `vale` binary is unavailable here. ## Risk notes - Docs only; `docs/reference/kpis.md` is the sole changed file. `apps/ploeg/docs/backlog.md`, tests and CI config are untouched (protected areas). - New links are external tracker URLs on the same instance the rest of the docs already use. Correct base branch is `development` (the tooling may default to `main`); please retarget if needed. Refs VIK-1289

agent-builder added 1 commit 2026-09-27 18:11:07 +00:00

docs(kpis): point the KPI proposal at VIK-1214/VIK-1215 and mark cfd6ec4 landed ... fec8fa9a49

The status line cited backlog #91/#92, which are Golden fixtures and CI
hardening, not the KPI work; link the KPI set (VIK-1214) and the dashboard
(VIK-1215) instead. The merge settlement cfd6ec4 is merged and released, so
K5/K6 no longer describe it as pending and data row D4 is marked done.
Refresh the page's last_verified/verified_by metadata.

VIK-1289
Agent-Trace-Id: ploeg-7b153d323153

agent-builder commented 2026-09-27 18:11:25 +00:00

Author

Member

Copy link

builder — round 1

openhands run opened a PR for docs(kpis): fix the backlog references for data tickets D1/D2 [Ploeg verification passed]

Ploeg verification

Ploeg ran the configured checks on commit fec8fa9a49fd after the agent finished.

Check	Result
if [ -f apps/ploeg/go.mod ]; then test -z "$(gofmt -l apps/ploeg)"; fi	passed

_{Posted by Ploeg for the writing Run that pushed this branch.}

### builder — round 1 _openhands run opened a PR for docs(kpis): fix the backlog references for data tickets D1/D2 [Ploeg verification passed]_ ### Ploeg verification Ploeg ran the configured checks on commit `fec8fa9a49fd` after the agent finished. | Check | Result | | --- | --- | | `if [ -f apps/ploeg/go.mod ]; then test -z "$(gofmt -l apps/ploeg)"; fi` | passed | _{Posted by Ploeg for the writing Run that pushed this branch.}

agent-builder commented 2026-09-27 18:17:11 +00:00

Author

Member

Copy link

reviewer — round 2

docs/reference/kpis.md meets all three ACs; offline docs-check core green, only mkdocs build left to CI; approve.

Verdict: approve

Docs-only change; all three acceptance criteria are met and the offline core of the docs check is green. Full mkdocs build --strict is not runnable in this sandbox and is correctly left to CI.

Scope

Single file changed: docs/reference/kpis.md (14 insertions / 14 deletions, no whitespace errors via git diff --check). HEAD fec8fa9a49fd, matching the PR head (PR #4, base development). No change to AGENTS.md, CLAUDE.md, .claude/, .agents/, .openhands/, .mcp.json or .cursorrules. Protected areas (apps/ploeg/docs/backlog.md, tests, CI config) untouched.

Acceptance criteria, each against the diff

1. AC1 met — docs/reference/kpis.md:11 now reads ... a proposal for [VIK-1214](https://vikunja.webgrip.dev/tasks/1214) (the KPI set) and [VIK-1215](https://vikunja.webgrip.dev/tasks/1215) (the dashboard). The old "backlog items #91 and #92" is gone.
2. AC2 met — grep -nE '#91|#92|not on development' docs/reference/kpis.md returns nothing (exit 1). Every cfd6ec4 mention now describes it as landed (:6, :23, :85, :270, :304) and data row D4 at :110 is **done**.
3. AC3 met, with one step left to CI — front matter is refreshed: last_verified: 2026-09-27 (:5) and a new verified_by (:6). The full mise run docs-check cannot run here (see Checks); its offline core passes.

Checks

• $PLOEG_VERIFY_SCRIPT (gofmt over apps/ploeg): passed, 1/1.
• mise run docs-check (uv run --frozen python scripts/docs.py --check): not runnable — uv cannot download its locked deps (six==1.17.0 from files.pythonhosted.org times out; no registry egress). I ran the equivalent offline parts directly with system python3 (PyYAML 6.0.3 present):
  • python3 scripts/docs.py --stage-only -> 376 sources, 1981 repository links, exit 0: no missing targets, no missing heading anchors, no line anchors, no moved-path detours, no orphans, and no front-matter failures. This is exactly the link/anchor/front-matter validation that covers this page.
  • Test scripts all exit 0: docs-rules, docs-output, agents-files, docs-decisions, docs-configuration, stage-explicit-paths, docs-vale, docs-live, tutorial-smoke (skips without PostgreSQL).
  • Generated-domain drift, combined glossary, landscape hashes, ADR consistency (3 ledgers), docs-decisions.py --check, docs-configuration.py --check, agents-files.py: all clean.
  • Not run: mkdocs build --strict and scripts/docs-output.py --site (MkDocs toolchain absent, no egress). Reported as not run, not as passed; the PR lists it under "Checks left to CI".

Factual corroboration

• The merge-settlement mechanism the page now describes does exist on development: apps/ploeg/pkg/shiftengine/review.go:103 returns work.StateDone, "pull request merged", and apps/ploeg/pkg/store/review.go:81 writes the ploegd:review / work_item.done audit row with detail.reason. K5's Source statement is accurate.
• The checkout is shallow (.git/shallow), so cfd6ec4 is not an object here and I could not independently confirm it is an ancestor of development. The Work Item asserts it is merged and released and the code path it describes is present; I treat the hash claim as ticket-asserted, corroborated by code, not independently verified.
• The VIK links are the same https://vikunja.webgrip.dev/tasks/<id> pattern the rest of the docs use; both returned HTTP 200 (Vikunja's SPA shell, so task content itself is not verifiable without a token).

Optional (non-blocking, do not hold this PR)

• verified_by (:6) is now narrower and partly self-referential: "source read of docs/reference/kpis.md and apps/ploeg/docs/backlog.md ... and the landed cfd6ec4 merge per VIK-1289". Reading the page itself does not verify the page, it cites VIK-1289 for a fact VIK-1289 merely asserts, and it drops the earlier provenance for the page's SQL/schema claims (pkg/store/migrations 0001-0016, pkg/store, pkg/shiftengine, pkg/provider/forgejo) while bumping last_verified to today. The documentation policy asks to name what you checked "including what you did not check". A stronger value would cite the actual source for this change (apps/ploeg/pkg/shiftengine/review.go, apps/ploeg/pkg/store/review.go) and say the rest of the page was not re-verified. The ACs only require the front matter to be updated, so this is an improvement, not a defect.
• docs/reference/kpis.md:54 and :192 still say "After commit 8148c1d lands". That commit is outside this Work Item (the ticket and its verification grep cover only cfd6ec4), so it is not a finding here — but if 8148c1d has also landed, the same staleness remains and deserves a follow-up ticket.

I checked: diff scope and whitespace, all three acceptance criteria, the Work Item grep, the offline docs-check core, and the PR description/base.

_{Posted by Ploeg on behalf of the reviewing agent. It could not push to this branch.}

### reviewer — round 2 _docs/reference/kpis.md meets all three ACs; offline docs-check core green, only mkdocs build left to CI; approve._ ## Verdict: approve Docs-only change; all three acceptance criteria are met and the offline core of the docs check is green. Full `mkdocs build --strict` is not runnable in this sandbox and is correctly left to CI. ### Scope Single file changed: `docs/reference/kpis.md` (14 insertions / 14 deletions, no whitespace errors via `git diff --check`). HEAD `fec8fa9a49fd`, matching the PR head (PR #4, base `development`). No change to `AGENTS.md`, `CLAUDE.md`, `.claude/`, `.agents/`, `.openhands/`, `.mcp.json` or `.cursorrules`. Protected areas (`apps/ploeg/docs/backlog.md`, tests, CI config) untouched. ### Acceptance criteria, each against the diff 1. **AC1 met** — `docs/reference/kpis.md:11` now reads `... a proposal for [VIK-1214](https://vikunja.webgrip.dev/tasks/1214) (the KPI set) and [VIK-1215](https://vikunja.webgrip.dev/tasks/1215) (the dashboard).` The old "backlog items #91 and #92" is gone. 2. **AC2 met** — `grep -nE '#91|#92|not on development' docs/reference/kpis.md` returns nothing (exit 1). Every `cfd6ec4` mention now describes it as landed (`:6`, `:23`, `:85`, `:270`, `:304`) and data row D4 at `:110` is `**done**`. 3. **AC3 met, with one step left to CI** — front matter is refreshed: `last_verified: 2026-09-27` (`:5`) and a new `verified_by` (`:6`). The full `mise run docs-check` cannot run here (see Checks); its offline core passes. ### Checks - `$PLOEG_VERIFY_SCRIPT` (gofmt over `apps/ploeg`): **passed**, 1/1. - `mise run docs-check` (`uv run --frozen python scripts/docs.py --check`): **not runnable** — uv cannot download its locked deps (`six==1.17.0` from files.pythonhosted.org times out; no registry egress). I ran the equivalent offline parts directly with system `python3` (PyYAML 6.0.3 present): - `python3 scripts/docs.py --stage-only` -> `376 sources, 1981 repository links`, exit 0: no missing targets, no missing heading anchors, no line anchors, no moved-path detours, no orphans, and no front-matter failures. This is exactly the link/anchor/front-matter validation that covers this page. - Test scripts all exit 0: `docs-rules`, `docs-output`, `agents-files`, `docs-decisions`, `docs-configuration`, `stage-explicit-paths`, `docs-vale`, `docs-live`, `tutorial-smoke` (skips without PostgreSQL). - Generated-domain drift, combined glossary, landscape hashes, ADR consistency (3 ledgers), `docs-decisions.py --check`, `docs-configuration.py --check`, `agents-files.py`: all clean. - **Not run:** `mkdocs build --strict` and `scripts/docs-output.py --site` (MkDocs toolchain absent, no egress). Reported as not run, not as passed; the PR lists it under "Checks left to CI". ### Factual corroboration - The merge-settlement mechanism the page now describes does exist on development: `apps/ploeg/pkg/shiftengine/review.go:103` returns `work.StateDone, "pull request merged"`, and `apps/ploeg/pkg/store/review.go:81` writes the `ploegd:review` / `work_item.done` audit row with `detail.reason`. K5's Source statement is accurate. - The checkout is shallow (`.git/shallow`), so `cfd6ec4` is not an object here and I could not independently confirm it is an ancestor of development. The Work Item asserts it is merged and released and the code path it describes is present; I treat the hash claim as ticket-asserted, corroborated by code, not independently verified. - The VIK links are the same `https://vikunja.webgrip.dev/tasks/<id>` pattern the rest of the docs use; both returned HTTP 200 (Vikunja's SPA shell, so task content itself is not verifiable without a token). ### Optional (non-blocking, do not hold this PR) - `verified_by` (`:6`) is now narrower and partly self-referential: "source read of `docs/reference/kpis.md` and `apps/ploeg/docs/backlog.md` ... and the landed cfd6ec4 merge per VIK-1289". Reading the page itself does not verify the page, it cites VIK-1289 for a fact VIK-1289 merely asserts, and it drops the earlier provenance for the page's SQL/schema claims (`pkg/store/migrations 0001-0016`, `pkg/store`, `pkg/shiftengine`, `pkg/provider/forgejo`) while bumping `last_verified` to today. The documentation policy asks to name what you checked "including what you did not check". A stronger value would cite the actual source for this change (`apps/ploeg/pkg/shiftengine/review.go`, `apps/ploeg/pkg/store/review.go`) and say the rest of the page was not re-verified. The ACs only require the front matter to be updated, so this is an improvement, not a defect. - `docs/reference/kpis.md:54` and `:192` still say "After commit `8148c1d` lands". That commit is outside this Work Item (the ticket and its verification grep cover only `cfd6ec4`), so it is not a finding here — but if `8148c1d` has also landed, the same staleness remains and deserves a follow-up ticket. I checked: diff scope and whitespace, all three acceptance criteria, the Work Item grep, the offline docs-check core, and the PR description/base. _{Posted by Ploeg on behalf of the reviewing agent. It could not push to this branch.}

ryangr0 added 1 commit 2026-09-28 03:40:53 +00:00

Merge branch 'development' into agent/vik-1289 d76aef32d7

ryangr0 merged commit 33a3cf6a35 into development 2026-09-28 04:11:47 +00:00

ryangr0 referenced this pull request from a commit 2026-09-28 04:11:48 +00:00

Merge pull request 'docs(kpis): point the KPI proposal at VIK-1214/VIK-1215 and mark cfd6ec4 landed' (#4) from agent/vik-1289 into development

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

webgrip/glide!4

No description provided.