fix(shiftengine): a roled plan that closes successfully settles at done

agent-builder commented

2026-08-26 09:42:57 +00:00

Member

No description provided.

agent-builder added 1 commit

2026-08-26 09:42:57 +00:00

fix(shiftengine): a roled plan that closes successfully settles at done

On Pull Request / checks (pull_request) Successful in 1m13s

Details

e6f2268ebe

close() parked every CONFIGURED plan's item at needs_human no matter how
well the run went, so a roled run that ended with the builder's pr_opened,
a reviewer's approval and close_reason review_approved still reached
needs_human. The roleless path reaches done from the identical pr_opened
outcome — the presence of a role was silently the discriminator (nine items
parked behind it on ploegd 0.2.0-rc.28).

Success is now earned, not inferred: closeSucceeded maps the loop's explicit
approval, and a plan that ran out with the last reviewer approving, to the
same terminal success state the roleless path uses. Every other close —
stuck, writer-failed, dry pool, fix-cap, a plan nobody approved — still
parks at needs_human. No new state, no migration: the configured path now
simply settles done where it previously settled needs_human.

Regression test: TestRoledPlan_ApproveSettlesDone covers builder -> reviewer
-> approve reaching terminal success, both under the loop's explicit approval
(review_approved) and a plan that runs out with the last verdict approving
(plan_exhausted). It fails against the pre-fix code, where close() settles
every configured plan at needs_human.

VIK-776
Agent-Trace-Id: ploeg-49ce3e1d33b0

Co-authored-by: openhands <openhands@all-hands.dev>

ryangr0 referenced this pull request from a commit

2026-09-23 12:05:53 +00:00

fix(ploeg): park an exhausted plan whose last review asked for changes

ryangr0 commented

2026-09-23 12:06:37 +00:00

Owner

Closing as superseded: Glide 8af4b75 settles a successful Shift at awaiting_review instead of done, and Glide 121b345 ports this PR's rule that a plan which runs out while the last review asks for changes settles at needs_human. Ploeg now lives in https://forgejo.webgrip.dev/webgrip/glide under apps/ploeg; this repository is being frozen.

ryangr0 closed this pull request

2026-09-23 12:06:39 +00:00

webgrip-ci referenced this pull request from a commit

2026-09-27 10:17:54 +00:00

chore(release): glide-v0.4.0-rc.1 [skip ci]

Rows
Columns

fix(shiftengine): a roled plan that closes successfully settles at done #43