fix(ploeg): keep edited but unpublished writer work from counting as done

ryangr0 commented

2026-10-03 12:06:54 +00:00

Owner

A writer that changed files and published nothing completed its Work
Item. resolveOutcome maps a clean exit with no pull request to
no_change_needed, and the ACP adapter itself reports no_change_needed
when no edit tool call completed, so an agent that edited through a
shell command looked like it had nothing to do. BuildMutatedWithoutPR,
which would have marked the run stuck, was never called.

The worker now records the commit a writer starts from and, when the
writer's outcome resolves to no_change_needed, compares the checkout
with it: uncommitted changes (git status, honouring .gitignore) or
commits on any local branch that are not on a remote end the Run stuck
with the paths and commits named. An unchanged checkout still completes.
The check sees edits from any tool, so BuildMutatedWithoutPR and the
changedFiles helper only it used are removed.

Rebased onto #158: worker.go keeps both the reviewed-commit checkpoint and the unpublished-work guard.

Verified with mise run verify on the pinned toolchain (all gates passed).

Ticket: https://vikunja.webgrip.dev/tasks/1737

🤖 Generated with Claude Code

A writer that changed files and published nothing completed its Work Item. resolveOutcome maps a clean exit with no pull request to no_change_needed, and the ACP adapter itself reports no_change_needed when no edit tool call completed, so an agent that edited through a shell command looked like it had nothing to do. BuildMutatedWithoutPR, which would have marked the run stuck, was never called. The worker now records the commit a writer starts from and, when the writer's outcome resolves to no_change_needed, compares the checkout with it: uncommitted changes (git status, honouring .gitignore) or commits on any local branch that are not on a remote end the Run stuck with the paths and commits named. An unchanged checkout still completes. The check sees edits from any tool, so BuildMutatedWithoutPR and the changedFiles helper only it used are removed. Rebased onto #158: worker.go keeps both the reviewed-commit checkpoint and the unpublished-work guard. Verified with `mise run verify` on the pinned toolchain (all gates passed). Ticket: https://vikunja.webgrip.dev/tasks/1737 🤖 Generated with [Claude Code](https://claude.com/claude-code)

ryangr0 added 1 commit

2026-10-03 12:06:54 +00:00

fix(ploeg): keep edited but unpublished writer work from counting as done

[Workflow] On Pull Request / checks (pull_request) Successful in 6m53s

Details

[Workflow] On Pull Request / warnings (pull_request) Waiting to run

Details

[Workflow] On Pull Request / release-policy (pull_request) Successful in 23s

Details

2392960e1a

A writer that changed files and published nothing completed its Work
Item. resolveOutcome maps a clean exit with no pull request to
no_change_needed, and the ACP adapter itself reports no_change_needed
when no edit tool call completed, so an agent that edited through a
shell command looked like it had nothing to do. BuildMutatedWithoutPR,
which would have marked the run stuck, was never called.

The worker now records the commit a writer starts from and, when the
writer's outcome resolves to no_change_needed, compares the checkout
with it: uncommitted changes (git status, honouring .gitignore) or
commits on any local branch that are not on a remote end the Run stuck
with the paths and commits named. An unchanged checkout still completes.
The check sees edits from any tool, so BuildMutatedWithoutPR and the
changedFiles helper only it used are removed.

VIK-1737

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

ryangr0 merged commit 44164b8375 into development

2026-10-03 12:18:23 +00:00

ryangr0 referenced this pull request from a commit

2026-10-03 12:18:23 +00:00

Merge pull request 'fix(ploeg): keep edited but unpublished writer work from counting as done' (#177) from ryangr0/ploeg-acp-unpublished-edits into development

ryangr0 referenced this pull request

2026-10-03 12:25:38 +00:00

fix(ploeg): read a writer's branch on the forge before it counts as no change or updated #188

ryangr0 referenced this pull request from a commit

2026-10-03 15:12:20 +00:00

fix(ploeg): read a writer's branch on the forge before it counts as no change or updated