fix(github): create the release over the REST API; drop GitHub-only annotations #51

Merged

ryangr0 merged 2 commits from chore/forgejo-native-diagnostics into main 2026-08-25 09:45:32 +00:00

Conversation 0 Commits 2 Files changed 5 +123 -46

ryangr0 commented 2026-08-25 05:40:57 +00:00

Owner

Copy link

Two changes to the Forgejo tree, both from chasing the ploeg GitHub track to green.

1. fix(github): create the release over the REST API, not the gh CLI

The Forgejo ci-runner image does not ship gh. ploeg run 181 mirrored every branch and tag to github.com successfully and then died on the next line:

line 18: gh: command not found

leaving the repo mirrored but with no GitHub Release — the one part of the GitHub track that had never actually run.

Installing gh would have been the wrong fix: another github.com download on the release path, which is exactly the dependency that keeps flaking here (the syft installer took the signing job down in runs 172 and 175, then recovered on its own in 177). curl and jq are already present, and this step already used both for the Forgejo API.

gh release view → GET /releases/tags/{tag}. gh release create → POST /releases with a jq-built payload. --verify-tag is preserved explicitly, because POST /releases will otherwise create the tag as a side effect, and a release pointing at a tag the mirror never pushed would be a silent lie. GH_HOST is dropped — it only ever configured the CLI.

Verified against a stubbed curl across all five branches: release already exists, tag not mirrored, create with Forgejo notes, create with generated notes, and a 422.

2. chore(forgejo): drop GitHub-only annotation commands from .forgejo/

::error:: / ::warning:: / ::notice:: create annotations on GitHub. On Forgejo they create nothing — act_runner re-emits the line with a ❗ marker but keeps the raw ::error:: text, and the job API has no field to put an annotation in. $GITHUB_STEP_SUMMARY is not an alternative either; Forgejo dumps it into the log as one line with literal \n.

All 34 cosmetic sites in .forgejo/ become plain ERROR: / WARN: / NOTE:, with operator-actionable remediation on the last lines before exit 1.

• ::add-mask:: untouched at all 5 sites — that one IS functional on act_runner and is what produces AUTHORIZATION: basic *** in checkout logs.
• .github/ untouched, per ADR 002 — the commands do real work there.
• README gains the convention, including the point that matters most: Forgejo's one structured surface is the step list, so a short well-named precondition step beats any log formatting.

Two changes to the Forgejo tree, both from chasing the ploeg GitHub track to green. ## 1. `fix(github)`: create the release over the REST API, not the `gh` CLI The Forgejo ci-runner image does not ship `gh`. ploeg run 181 mirrored every branch and tag to github.com successfully and then died on the next line: ``` line 18: gh: command not found ``` leaving the repo mirrored but with **no GitHub Release** — the one part of the GitHub track that had never actually run. Installing `gh` would have been the wrong fix: another github.com download on the release path, which is exactly the dependency that keeps flaking here (the syft installer took the signing job down in runs 172 and 175, then recovered on its own in 177). `curl` and `jq` are already present, and this step already used both for the Forgejo API. `gh release view` → `GET /releases/tags/{tag}`. `gh release create` → `POST /releases` with a jq-built payload. `--verify-tag` is preserved explicitly, because `POST /releases` will otherwise **create the tag as a side effect**, and a release pointing at a tag the mirror never pushed would be a silent lie. `GH_HOST` is dropped — it only ever configured the CLI. Verified against a stubbed curl across all five branches: release already exists, tag not mirrored, create with Forgejo notes, create with generated notes, and a 422. ## 2. `chore(forgejo)`: drop GitHub-only annotation commands from `.forgejo/` `::error::` / `::warning::` / `::notice::` create annotations on GitHub. On Forgejo they create nothing — `act_runner` re-emits the line with a `❗` marker but keeps the raw `::error::` text, and the job API has no field to put an annotation in. `$GITHUB_STEP_SUMMARY` is not an alternative either; Forgejo dumps it into the log as one line with literal `\n`. All 34 cosmetic sites in `.forgejo/` become plain `ERROR:` / `WARN:` / `NOTE:`, with operator-actionable remediation on the last lines before `exit 1`. - **`::add-mask::` untouched** at all 5 sites — that one IS functional on act_runner and is what produces `AUTHORIZATION: basic ***` in checkout logs. - **`.github/` untouched**, per ADR 002 — the commands do real work there. - README gains the convention, including the point that matters most: Forgejo's one structured surface is the **step list**, so a short well-named precondition step beats any log formatting.

ryangr0 added 1 commit 2026-08-25 05:40:57 +00:00

chore(forgejo): drop GitHub-only annotation commands from the .forgejo tree ... a5c5b5f7ad

`::error::` / `:⚠️:` / `::notice::` buy nothing on Forgejo. act_runner
re-emits the line with a `❗` marker but keeps the raw `::error::` text, and the
job view has no annotations surface to put it on — so the only effect is an
uglier log line. Verified against the ploeg run 172 job API: `currentJob` is
just title/details/steps/allAttempts, with nowhere for an annotation to land.
`$GITHUB_STEP_SUMMARY` is no better; Forgejo dumps it into the log as one line
with literal `\n` sequences.

All 34 cosmetic sites in `.forgejo/` become plain `ERROR:` / `WARN:` / `NOTE:`
prefixes, and the operator-actionable ones (the GH_TOKEN preflights) become
short blocks with the remediation on the last lines before `exit 1` — the log
tail is what you land on when you expand a failed step. Kept on stdout: Forgejo
merges both streams into one untagged log, and separate buffers only risk
reordering the block.

`::add-mask::` is left alone at all 5 sites — that one IS functional on
act_runner, and is what produces `AUTHORIZATION: basic ***` in checkout logs.

`.github/` is untouched, per ADR 002: the commands do real work there.

README gains the convention, next to the existing Forgejo-divergence callout,
including the point that matters most — Forgejo's one structured surface is the
step list, so a short well-named precondition step beats any log formatting.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

ryangr0 added 1 commit 2026-08-25 09:40:42 +00:00

fix(github): create the release over the REST API, not the gh CLI ... 0f2c5a56f8

The Forgejo ci-runner image does not ship `gh`. ploeg run 181 mirrored every
branch and tag to github.com successfully and then died on the next line with

    line 18: gh: command not found

leaving the repo mirrored but with no GitHub Release — the one part of the
GitHub track that had never actually run.

Installing gh was the wrong fix: it would put another github.com download on
the release path, which is precisely the dependency that keeps flaking here
(the syft installer took the signing job down in runs 172 and 175, and
recovered on its own in 177). curl and jq are already present and this step
already used both for the Forgejo API.

`gh release view` becomes GET /releases/tags/{tag}, and `gh release create`
becomes POST /releases with a jq-built payload. `--verify-tag` is preserved
explicitly, because POST /releases will otherwise CREATE the tag as a side
effect and a release pointing at a tag the mirror never pushed would be a
silent lie. GH_HOST is dropped; it only ever configured the gh CLI.

Verified by running the step body against a stubbed curl across all five
branches: release already exists, tag not mirrored, create with Forgejo notes,
create with generated notes, and a 422 from the API.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

ryangr0 changed title from chore(forgejo): drop GitHub-only annotation commands from the .forgejo tree to fix(github): create the release over the REST API; drop GitHub-only annotations 2026-08-25 09:41:04 +00:00

ryangr0 merged commit 173b59843b into main 2026-08-25 09:45:32 +00:00

ryangr0 referenced this pull request from a commit 2026-08-25 09:45:33 +00:00

Merge pull request 'fix(github): create the release over the REST API; drop GitHub-only annotations' (#51) from chore/forgejo-native-diagnostics into main

webgrip-ci referenced this pull request from a commit 2026-08-25 09:46:30 +00:00

chore(release): v1.9.2 [skip ci]

renovate referenced this pull request from webgrip/twente.dev 2026-09-19 12:46:44 +00:00

fix(actions): Update dependency webgrip/workflows ( v1.6.0 ➔ v1.11.3 ) #21

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

pull-request

Mirrored from GitHub Pull Request

No labels

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

webgrip/workflows!51

No description provided.